BryanMLima commented on PR #10124:
URL: https://github.com/apache/cloudstack/pull/10124#issuecomment-2554202700

   > @BryanMLima
   > 
   > Found this small minor issue during filtering of vpc based on account 
domain
   > 
   >     1. Create domain and subdomain
   > 
   >     2. Create vpc under admin , domain and subdomain
   > 
   >     3. Navigate to filter under vpc , select the account
   > 
   >     4. Cloudstack UI doesn't list the vpc's that belong to the account
   > 
   >     5. Exception is thrown
   > 
   >     6. select the domain , domain selection doesn't persist
   > 
   > 
   > The API call works fine
   > 
   > ```
   > 
   > (localcloud) 🐱 > list vpcs listall=true account=acdm1 
domainid=9298426a-82a2-40a6-9830-2569124dff0d filter=name
   > {
   >   "count": 1,
   >   "vpc": [
   >     {
   >       "name": "vpc1"
   >     }
   >   ]
   > }
   > (localcloud) 🐱 > list vpcs listall=true account=subdomain1  
domainid=10cf3a25-b0fc-4501-93e0-8ecc4d355544  filter=name
   > {
   >   "count": 1,
   >   "vpc": [
   >     {
   >       "name": "subdomainvpc"
   >     }
   >   ]
   > }
   > ```
   > 
   > Screen recording
   > 
   > 
https://www.loom.com/share/bcef796e0f894f10a2a3f4952db8d240?sid=b0eda87f-73cf-4db9-b7b3-aa16f9b143b4
   
   @kiranchavala, nice catch, though, this seems related to the `ListView.vue` 
file. I did some testing, and the problem is that when filtering for an account 
for VPC, if the domain is not specified, then the account will not be found. In 
the CMK command you presented, the `domainId` is passed, therefore, the account 
is found. This probably affects more resources views, as the `ListView.vue` is 
used in multiple cases.
   
   I also tested the filter in other resources views, such as VM and Guest 
networks, and the domain is never set. I will try to investigate further, but 
this fix should be on another PR, as it is not related to this PR's changes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to