JoaoJandre commented on code in PR #10093:
URL: https://github.com/apache/cloudstack/pull/10093#discussion_r1886646764
##########
plugins/storage/volume/linstor/src/main/java/com/cloud/hypervisor/kvm/storage/LinstorStorageAdaptor.java:
##########
@@ -311,12 +313,13 @@ public boolean connectPhysicalDisk(String volumePath,
KVMStoragePool pool, Map<S
throw new CloudRuntimeException(apiEx.getBestMessage(), apiEx);
}
- try
- {
- allow2PrimariesIfInUse(api, rscName);
- } catch (ApiException apiEx) {
- s_logger.error(apiEx);
- // do not fail here as adding allow-two-primaries property is only
a problem while live migrating
+ if (isVMMigration) {
+ try {
+ allow2PrimariesIfInUse(api, rscName);
+ } catch (ApiException apiEx) {
+ s_logger.error(apiEx);
+ // do not fail here as adding allow-two-primaries property is
only a problem while live migrating
+ }
Review Comment:
Just to see if I got it right: your problem was that the agent got stuck,
the other hosts said it was down and the 'HA' was triggered, so the VM was
started on another host, even though it was already running in the host that
got stuck?
If so, on Linstor, in this process, why would the VM be using two primaries
(if this is what's happening)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
