DaanHoogland commented on code in PR #10017:
URL: https://github.com/apache/cloudstack/pull/10017#discussion_r1873248083
##########
server/src/main/java/com/cloud/configuration/Config.java:
##########
@@ -1447,8 +1447,8 @@ public enum Config {
DefaultMaxDomainPublicIPs("Domain Defaults", ManagementServer.class,
Long.class, "max.domain.public.ips", "40", "The default maximum number of
public IPs that can be consumed by a domain", null),
DefaultMaxDomainTemplates("Domain Defaults", ManagementServer.class,
Long.class, "max.domain.templates", "40", "The default maximum number of
templates that can be deployed for a domain", null),
DefaultMaxDomainSnapshots("Domain Defaults", ManagementServer.class,
Long.class, "max.domain.snapshots", "40", "The default maximum number of
snapshots that can be created for a domain", null),
- DefaultMaxDomainBackups("Domain Defaults", ManagementServer.class,
Long.class, "max.domain.backups", "-1", "The default maximum number of backups
that can be created for a domain", null),
- DefaultMaxDomainBackupStorage("Domain Defaults", ManagementServer.class,
Long.class, "max.domain.backup.storage", "-1", "The default maximum backup
storage space (in GiB) that can be used for a domain", null),
+ DefaultMaxDomainBackups("Domain Defaults", ManagementServer.class,
Long.class, "max.domain.backups", "40", "The default maximum number of backups
that can be created for a domain", null),
+ DefaultMaxDomainBackupStorage("Domain Defaults", ManagementServer.class,
Long.class, "max.domain.backup.storage", "800", "The default maximum backup
storage space (in GiB) that can be used for a domain", null),
Review Comment:
we should take this oportunity to take these out of this array and put them
in the respective orchestration classes/services.
##########
server/src/main/java/com/cloud/configuration/Config.java:
##########
@@ -1457,9 +1457,8 @@ public enum Config {
DefaultMaxDomainPrimaryStorage("Domain Defaults", ManagementServer.class,
Long.class, "max.domain.primary.storage", "400", "The default maximum primary
storage space (in GiB) that can be used for a domain", null),
DefaultMaxDomainSecondaryStorage("Domain Defaults",
ManagementServer.class, Long.class, "max.domain.secondary.storage", "800", "The
default maximum secondary storage space (in GiB) that can be used for a
domain", null),
DefaultMaxDomainProjects("Domain
Defaults",ManagementServer.class,Long.class,"max.domain.projects","50","The
default maximum number of projects that can be created for a domain",null),
- // Move to configkey?
- DefaultMaxDomainBuckets("Domain Defaults", ManagementServer.class,
Long.class, "max.domain.buckets", "-1", "The default maximum number of buckets
that can be created for a domain", null),
- DefaultMaxDomainObjectStorage("Domain Defaults", ManagementServer.class,
Long.class, "max.domain.object.storage", "-1", "The default maximum object
storage space (in GiB) that can be used for a domain", null),
+ DefaultMaxDomainBuckets("Domain Defaults", ManagementServer.class,
Long.class, "max.domain.buckets", "40", "The default maximum number of buckets
that can be created for a domain", null),
+ DefaultMaxDomainObjectStorage("Domain Defaults", ManagementServer.class,
Long.class, "max.domain.object.storage", "800", "The default maximum object
storage space (in GiB) that can be used for a domain", null),
Review Comment:
same here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
