This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch 4.19
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/4.19 by this push:
     new 006db90f75b kvm: fix ovs network creation issue (#9869)
006db90f75b is described below

commit 006db90f75b562a4d0fc8e0346a0fabe98ea1484
Author: Wei Zhou <weiz...@apache.org>
AuthorDate: Thu Nov 7 10:06:53 2024 +0100

    kvm: fix ovs network creation issue (#9869)
    
    This fixes the issue when create a ovs network
    ```
    2024-10-29 16:02:45,089 WARN  
[resource.wrapper.LibvirtOvsFetchInterfaceCommandWrapper] 
(agentRequest-Handler-2:null) (logid:e716722e) Network interface: ''cloudbr1'' 
not found
    ```
    
    This is a regression of a previous security release
    see "framework/cluster: improve cluster service, integration API server"
    
    since we now use NetworkInterface.getByName to get network interface, we 
should NOT add single quotes before/after the label.
---
 .../kvm/resource/wrapper/LibvirtOvsFetchInterfaceCommandWrapper.java    | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git 
a/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtOvsFetchInterfaceCommandWrapper.java
 
b/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtOvsFetchInterfaceCommandWrapper.java
index 117a832a68b..d2823334a8c 100644
--- 
a/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtOvsFetchInterfaceCommandWrapper.java
+++ 
b/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtOvsFetchInterfaceCommandWrapper.java
@@ -92,7 +92,7 @@ public final class LibvirtOvsFetchInterfaceCommandWrapper 
extends CommandWrapper
 
     @Override
     public Answer execute(final OvsFetchInterfaceCommand command, final 
LibvirtComputingResource libvirtComputingResource) {
-        final String label = "'" + command.getLabel() + "'";
+        final String label = command.getLabel();
 
         s_logger.debug("Will look for network with name-label:" + label);
         try {

Reply via email to