weizhouapache commented on code in PR #9840:
URL: https://github.com/apache/cloudstack/pull/9840#discussion_r1830795370
##########
api/src/main/java/org/apache/cloudstack/api/command/admin/domain/ListDomainsCmd.java:
##########
@@ -142,7 +142,10 @@ protected void updateDomainResponse(List<DomainResponse>
response) {
if (CollectionUtils.isEmpty(response)) {
return;
}
-
_resourceLimitService.updateTaggedResourceLimitsAndCountsForDomains(response,
getTag());
+ EnumSet<DomainDetails> details = getDetails();
+ if (details.contains(DomainDetails.all) ||
details.contains(DomainDetails.resource)) {
+
_resourceLimitService.updateTaggedResourceLimitsAndCountsForDomains(response,
getTag());
Review Comment:
ok, it is good if we get this in 4.20.1
##########
api/src/main/java/org/apache/cloudstack/api/command/user/account/ListAccountsCmd.java:
##########
@@ -149,7 +149,10 @@ protected void updateAccountResponse(List<AccountResponse>
response) {
if (CollectionUtils.isEmpty(response)) {
return;
}
-
_resourceLimitService.updateTaggedResourceLimitsAndCountsForAccounts(response,
getTag());
+ EnumSet<DomainDetails> details = getDetails();
+ if (details.contains(DomainDetails.all) ||
details.contains(DomainDetails.resource)) {
+
_resourceLimitService.updateTaggedResourceLimitsAndCountsForAccounts(response,
getTag());
Review Comment:
it is good if we get this in 4.20.1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
