DaanHoogland commented on code in PR #9822:
URL: https://github.com/apache/cloudstack/pull/9822#discussion_r1819160819
##########
systemvm/debian/opt/cloud/bin/cs/CsFile.py:
##########
@@ -175,6 +175,6 @@ def deleteLine(self, search):
self.new_config = list(temp_config)
def compare(self, o):
- result = (isinstance(o, self.__class__) and set(self.config) ==
set(o.config))
+ result = (isinstance(o, self.__class__) and self.config == o.config)
Review Comment:
So this means that we no longer compare the set to be equal but the line by
line items (in order). Is that really what we want @weizhouapache ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
