vishesh92 commented on PR #8756:
URL: https://github.com/apache/cloudstack/pull/8756#issuecomment-2421306987
> > > > @weizhouapache given the DRS piece is a new feature, if there are
changes that must be made - rather DRS than the base response class. cc
@vishesh92 to review & advise.
> > >
> > >
> > > this PR has renamed the variables and serialized name of job id and
job status in ClusterDrsPlanMigrationResponse.java
> > > not sure if there are regression caused by the renaming (smoke test
looks good)
> > > cc @vishesh92 @rohityadavcloud @nvazquez
> >
> >
> > The changes related to drs looks good. I need to check but this might
require some changes in the UI.
>
> thanks @vishesh92 do you mean the `jobstatus` below ?
>
> ```
> ui/src/views/infra/ClusterDRSTab.vue: {{ text.migrations.filter(m
=> m.jobstatus === 'SUCCEEDED').length }} / {{ text.migrations.length }}
> ui/src/views/infra/ClusterDRSTab.vue: key: 'jobstatus',
> ui/src/views/infra/ClusterDRSTab.vue: dataIndex: 'jobstatus'
> ```
Yes. This one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
