abh1sar commented on code in PR #9666:
URL: https://github.com/apache/cloudstack/pull/9666#discussion_r1804399334
##########
server/src/main/java/org/apache/cloudstack/backup/BackupManagerImpl.java:
##########
@@ -470,16 +468,30 @@ public List<BackupSchedule> listBackupSchedule(final Long
vmId) {
@Override
@ActionEvent(eventType = EventTypes.EVENT_VM_BACKUP_SCHEDULE_DELETE,
eventDescription = "deleting VM backup schedule")
- public boolean deleteBackupSchedule(final Long vmId) {
- final VMInstanceVO vm = findVmById(vmId);
- validateForZone(vm.getDataCenterId());
- accountManager.checkAccess(CallContext.current().getCallingAccount(),
null, true, vm);
+ public boolean deleteBackupSchedule(DeleteBackupScheduleCmd cmd) {
+ Long vmId = cmd.getVmId();
+ Long id = cmd.getId();
+ if (Objects.nonNull(vmId)) {
Review Comment:
In DeleteBackupScheduleCmd, both `vmId` and `id` parameters are declared
with `required = true`, but here it looks like either of them could be null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
