sureshanaparti commented on code in PR #9787:
URL: https://github.com/apache/cloudstack/pull/9787#discussion_r1801121796
##########
server/src/main/java/org/apache/cloudstack/vm/UnmanagedVMsManagerImpl.java:
##########
@@ -1598,11 +1600,13 @@ protected UserVm
importUnmanagedInstanceFromVmwareToKvm(DataCenter zone, Cluster
String ovfTemplateOnConvertLocation = null;
try {
HostVO convertHost =
selectInstanceConversionKVMHostInCluster(destinationCluster,
convertInstanceHostId);
+ HostVO importHost = convertInstanceHostId == null ? convertHost :
selectInstanceConversionKVMHostInCluster(destinationCluster, null);
Review Comment:
convert and import host need not be the same, in case of same destination
cluster used for conversion (can take import host from input? if not provided,
let CS choose the import host from destination cluster).
keep separate methods for conversion host and import host selection. also,
better support disabled host used for conversion (not for import - as it needs
resource allocation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
