Pearl1594 commented on code in PR #9773:
URL: https://github.com/apache/cloudstack/pull/9773#discussion_r1794435420
##########
ui/src/config/section/compute.js:
##########
@@ -207,9 +207,10 @@ export default {
docHelp:
'adminguide/virtual_machines.html#virtual-machine-snapshots',
dataView: true,
popup: true,
- show: (record) => {
- return ((['Running'].includes(record.state) && record.hypervisor
!== 'LXC') ||
- (['Stopped'].includes(record.state) && !['KVM',
'LXC'].includes(record.hypervisor)))
+ show: (record, store) => {
+ return (record.hypervisor !== 'KVM') ||
Review Comment:
why destroyed state?
##########
ui/src/config/section/storage.js:
##########
@@ -179,9 +180,10 @@ export default {
label: 'label.action.recurring.snapshot',
dataView: true,
show: (record, store) => {
- return record.state === 'Ready' && (record.hypervisor !== 'KVM' ||
- record.hypervisor === 'KVM' && record.vmstate === 'Running' &&
store.features.kvmsnapshotenabled ||
- record.hypervisor === 'KVM' && record.vmstate !== 'Running')
+ return record.state === 'Ready' &&
+ (record.hypervisor !== 'KVM' ||
+ (['Stopped', 'Destroyed'].includes(record.vmstate)) ||
Review Comment:
same doubt as above
##########
ui/src/config/section/storage.js:
##########
@@ -165,9 +165,10 @@ export default {
label: 'label.action.take.snapshot',
dataView: true,
show: (record, store) => {
- return record.state === 'Ready' && (record.hypervisor !== 'KVM' ||
- record.hypervisor === 'KVM' && record.vmstate === 'Running' &&
store.features.kvmsnapshotenabled ||
- record.hypervisor === 'KVM' && record.vmstate !== 'Running')
+ return record.state === 'Ready' &&
+ (record.hypervisor !== 'KVM' ||
+ ['Stopped', 'Destroyed'].includes(record.vmstate) ||
Review Comment:
same here, why destroyed state ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
