DaanHoogland commented on PR #8503:
URL: https://github.com/apache/cloudstack/pull/8503#issuecomment-2367394302

   > @DaanHoogland is name used for instances when displayname may be empty or 
not returned by the API? (or perhaps is it handled by the backend API?)
   
   I see no mitigation of this possibility in a generic execution branch. The 
only path I encounter is 
   ```
           if (displayName == null) {
               displayName = vm.getDisplayName();
           }
   ```
   
   So I created a PR to deal with it : #9719  . I think this is not necessary 
as I have never seen an empty displayname before, but better safe than sorry ;)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to