weizhouapache commented on code in PR #9680:
URL: https://github.com/apache/cloudstack/pull/9680#discussion_r1762556337
##########
engine/schema/src/main/resources/META-INF/db/schema-41910to42000.sql:
##########
@@ -193,8 +193,8 @@ CREATE TABLE `cloud`.`ip4_guest_subnet_network_map` (
CONSTRAINT `uc_ip4_guest_subnet_network_map__uuid` UNIQUE (`uuid`)
) ENGINE=InnoDB DEFAULT CHARSET=utf8;
-ALTER TABLE `cloud`.`network_offerings` RENAME COLUMN `nsx_mode` TO
`network_mode`;
-ALTER TABLE `cloud`.`vpc_offerings` RENAME COLUMN `nsx_mode` TO `network_mode`;
+CALL `cloud`.`IDEMPOTENT_CHANGE_COLUMN`('network_offerings', 'nsx_mode',
'network_mode', 'varchar(32) COMMENT "mode in which the network would route
traffic"');
+CALL `cloud`.`IDEMPOTENT_CHANGE_COLUMN`('vpc_offerings', 'nsx_mode',
'network_mode', 'varchar(32) COMMENT "mode in which the network would route
traffic"');
ALTER TABLE `cloud`.`event` MODIFY COLUMN `type` varchar(50) NOT NULL;
Review Comment:
`MODIFY COLUMN` should be ok, it is being used in some other SQLs
it looks like the only problem is `RENAME COLUMN`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
