gpordeus opened a new pull request, #9692: URL: https://github.com/apache/cloudstack/pull/9692
### Description This PR adds the "ownership selection" UI fields to VPC tiers and VPC public IPs. The "vpcAccess" response attribute was added so the UI can know if the caller has access to the VPC without needing to make a whole new request. This is needed to avoid 404 links (since router.resolve is assembled through API permissions) and so the UI can present the correct public IPs to their possible network tiers (e.g. if the User has tiers of two different VPCs, they can't use one's public IP in the other). ### Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [X] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) - [ ] build/CI - [ ] test (unit or integration test code) ### Feature/Enhancement Scale or Bug Severity #### Feature/Enhancement Scale - [ ] Major - [X] Minor #### Bug Severity - [ ] BLOCKER - [ ] Critical - [ ] Major - [ ] Minor - [ ] Trivial ### Screenshots (if appropriate): <details> <summary>New tier possible owners' listing </summary>  </details> <details> <summary>Tier listing</summary>  </details> <details> <summary>User accessing their tier of the Admin's VPC</summary>  </details> <details> <summary>Possible owners for new IP</summary>  </details> ### How Has This Been Tested? Environment with domains Root (with accounts Root Admin and User), Root/1 (with a Domain Admin), Root/A (with a Domain Admin) and Root/A/B (with a Domain Admin and a User). There is a Project in each domain, owned by the respective admins. | Situation | Test | | ------------- | ------------- | | As Root Admin with VPC owned by self. | Every account and project listed as possible owners in Tier creation | | As Root Admin with VPC owned by self and one tier for each account and project. | Every account and project listed as possible owners in acquiring public IP. | | Same as previous, but remove some of the tiers. | The deleted tiers' owners also disappeared from IP possible owners' list, except Root Admin itself. | | As Root Admin with VPC owned by self, create one tier with a private ACL for the User. | User's access to network page did not present the 'ACL' attribute. | | As Root Admin with VPC owned by self, create one tier with a global ACL for the User. | User's access to network page showed 'ACL' attribute. | #### How did you try to break this feature and the system with this change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
