DaanHoogland commented on code in PR #9677:
URL: https://github.com/apache/cloudstack/pull/9677#discussion_r1760685609


##########
core/src/main/java/com/cloud/agent/api/CheckOnHostCommand.java:
##########
@@ -37,6 +37,7 @@ public CheckOnHostCommand(Host host) {
     public CheckOnHostCommand(Host host, boolean 
reportCheckFailureIfOneStorageIsDown) {
         super();
         this.host = new HostTO(host);
+        setWait(20);

Review Comment:
   I have some issues with this. As `super()` is called wait is set explicitely 
to 0 (zero). Either we should not call `super()` but `this(host)` or not set 
the wait value here.
   
   makes sense?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to