slavkap commented on code in PR #9478:
URL: https://github.com/apache/cloudstack/pull/9478#discussion_r1749759157
##########
engine/api/src/main/java/org/apache/cloudstack/engine/subsystem/api/storage/DataStoreCapabilities.java:
##########
@@ -40,5 +40,14 @@ public enum DataStoreCapabilities {
/**
* indicates that this driver supports reverting a volume to a snapshot
state
*/
- CAN_REVERT_VOLUME_TO_SNAPSHOT
+ CAN_REVERT_VOLUME_TO_SNAPSHOT,
+ /**
+ * indicates that the driver supports copying snapshot between zones on
pools of the same type
+ */
+ CAN_COPY_SNAPSHOT_BETWEEN_ZONES_AND_SAME_POOL_TYPE,
+ /**
+ * indicates that the storage does not need to delete the snapshot when
creating a volume/template from it
+ * and the setting `snapshot.backup.to.secondary` is enabled
+ */
+ KEEP_SNAPSHOT_ON_PRIMARY_AND_BACKUP
Review Comment:
@sureshanaparti, I don't want to give this option to the users, that's how
the StorPool plugin works. Would it be better to check that the pool type is
StorPool instead of adding a new capability?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
