rohityadavcloud commented on code in PR #9518: URL: https://github.com/apache/cloudstack/pull/9518#discussion_r1741988221
########## framework/db/src/main/java/com/cloud/utils/db/TransactionLegacy.java: ########## @@ -95,6 +98,8 @@ public class TransactionLegacy implements Closeable { } } + private static final String CONNECTION_POOL_LIB_DBCP = "dbcp"; Review Comment: @shwstppr minor - can we change the default to hikaricp, so when not defined hikaricp is used; otherwise we honour one of which is defined in db.properties ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org