BryanMLima commented on code in PR #7226:
URL: https://github.com/apache/cloudstack/pull/7226#discussion_r1729275973
##########
server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java:
##########
@@ -1229,8 +1229,8 @@ public VolumeVO resizeVolume(ResizeVolumeCmd cmd) throws
ResourceAllocationExcep
validateIops(newMinIops, newMaxIops, volume.getPoolType());
} else {
- newMinIops = newDiskOffering.getMinIops();
- newMaxIops = newDiskOffering.getMaxIops();
+ newMinIops = newDiskOffering.getMinIops() != null ?
newDiskOffering.getMinIops() : newDiskOffering.getIopsReadRate();
+ newMaxIops = newDiskOffering.getMaxIops() != null ?
newDiskOffering.getMaxIops() : newDiskOffering.getIopsWriteRate();
Review Comment:
AFAIK, VMware only allows IOPS limitation, if the offering has any kind of
limitation, we should set this limitation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
