gpordeus opened a new pull request, #8878:
URL: https://github.com/apache/cloudstack/pull/8878

   ### Description
   
   This PR adds the API `extractSnapshot` so one can download volume snapshots 
that are backed up on secondary storage.
   
   It checks if extraction is disabled and, if caller has access and the 
snapshot was found, it returns the download url, in the same way as 
Template/ISO extraction.
   
   It adds the `download_url` and `download_url_created` columns to 
`snapshot_store_ref` table and adds a download button to the GUI volume 
snapshot page.
   
   It also extracts duplicate code of Template/ISO and Volume Extraction around 
ExtractResponse.
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [X] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   - [ ] build/CI
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Feature/Enhancement Scale
   
   - [ ] Major
   - [X] Minor
   
   
   ### Screenshots (if appropriate):
   
   
   ### How Has This Been Tested?
   I deployed a ubuntu VM, took a volume snapshot and downloaded it through the 
UI.
   
   I then uploaded the volume to ACS, deployed a new VM, attached the uploaded 
volume to it so it becomes READY, stopped the VM, detached both volumes, and 
attached the uploaded volume again, this time as ROOT. 
   
   Next, I started the second VM and verified that it was running and that I 
could access it through the console.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to