Re: [PR] Enable Security groups for Shared networks in Advanced zone without security groups [cloudstack]

[via GitHub]

weizhouapache commented on code in PR #9415:
URL: https://github.com/apache/cloudstack/pull/9415#discussion_r1706559063


##########
ui/src/views/infra/network/ServiceProvidersTab.vue:
##########
@@ -937,10 +937,38 @@ export default {
             }
           ]
         },
-        // {
-        //   title: 'SecurityGroupProvider',
-        //   details: ['name', 'state', 'id', 'servicelist'],
-        // },
+        {
+          title: 'SecurityGroupProvider',

Review Comment:
   is it disabled by default in advanced zone ?
   can you add a doc PR to tell how to support SG ? it seems users only need to 
enable the provider ?
   
   can SG be supported per network (or network offering) or per account ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org