weizhouapache commented on code in PR #9470:
URL: https://github.com/apache/cloudstack/pull/9470#discussion_r1704107019


##########
server/src/main/java/com/cloud/api/ApiResponseHelper.java:
##########
@@ -2719,6 +2750,29 @@ public NetworkResponse 
createNetworkResponse(ResponseView view, Network network)
         response.setBytesReceived(bytesReceived);
         response.setBytesSent(bytesSent);
 
+        if 
(networkOfferingDao.isRoutedNetwork(network.getNetworkOfferingId())) {

Review Comment:
   @shwstppr 
   I had another look at thes issue in the search of networks (#9184 aimed to 
fix) and vms (#8012 aimed to fix)
   it looks both issues are related to the query on the tables (not the 
creation of response).
   Also `view` do not help sometimes, if there are several join tables (see 
#8012).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to