BryanMLima commented on code in PR #9074:
URL: https://github.com/apache/cloudstack/pull/9074#discussion_r1678304269


##########
server/src/main/java/com/cloud/agent/manager/allocator/impl/TestingAllocator.java:
##########
@@ -28,32 +28,24 @@
 import com.cloud.host.Host;
 import com.cloud.host.Host.Type;
 import com.cloud.host.dao.HostDao;
-import com.cloud.offering.ServiceOffering;
 import com.cloud.utils.component.AdapterBase;
-import com.cloud.vm.VirtualMachine;
 import com.cloud.vm.VirtualMachineProfile;
 
 public class TestingAllocator extends AdapterBase implements HostAllocator {

Review Comment:
   @DaanHoogland, because `TestingAllocator` does not have any methods in 
common with `BaseAllocator`. Is there a reason that it should extend it?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to