DaanHoogland commented on PR #9385: URL: https://github.com/apache/cloudstack/pull/9385#issuecomment-2228408882
> > > Nice work @DaanHoogland! > > > ~I believe we could do the same for the `cloud_usage` stored procedures.~ > > > Should we separate the `cloud_usage` in different files? > > > > > > I thought of that but wanted to check versions against each other. I will make that change. > > @DaanHoogland I was thinking a little bit more about this, and, except for `ADD_GUEST_OS_AND_HYPERVISOR_MAPPING`, the other procedures are valid for both `cloud` and `cloud_usage`. Perhaps we could execute the script once for each schema instead of duplicating the code. What do you think? that sounds good, but so far creating envs with this code doesn't work. I am not sure why yet, but giving that priority. (will keep it in mind though) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
