sureshanaparti commented on PR #9382:
URL: https://github.com/apache/cloudstack/pull/9382#issuecomment-2225510793
> code lgtm
>
> Do we need this in 4.18 as well? Maybe we can also add
`networkInterface.getName().startsWith("en")` which may allow the test to run
on Mac
>
> Maybe something like
`networkInterface.getName().matches("^(eth|en|wl).*")` for cleaner code
I think, need this in 4.18, i'll rebase to it.
I added "en" check earlier and removed as it's Libvirt/KVM test, should be
fine for unit test - will add that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
