rohityadavcloud commented on code in PR #9377:
URL: https://github.com/apache/cloudstack/pull/9377#discussion_r1675442032


##########
plugins/user-authenticators/saml2/src/main/java/org/apache/cloudstack/api/command/SAML2LoginAPIAuthenticatorCmd.java:
##########
@@ -228,6 +228,7 @@ public String authenticate(final String command, final 
Map<String, Object[]> par
                             "Received SAML response for a SSO request that we 
may not have made or has expired, please try logging in again",
                             params, responseType));
                 }
+                samlAuthManager.purgeToken(token);

Review Comment:
   this isn't very useful for now; but potentially guards against any replays 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to