rohityadavcloud commented on code in PR #9367:
URL: https://github.com/apache/cloudstack/pull/9367#discussion_r1673906935
##########
engine/schema/src/main/java/com/cloud/usage/dao/UsageDaoImpl.java:
##########
@@ -483,6 +483,8 @@ public void removeOldUsageRecords(int days) {
s_logger.error("error removing old cloud_usage records for
interval: " + days);
} finally {
txn.close();
+ TransactionLegacy swap =
TransactionLegacy.open(TransactionLegacy.CLOUD_DB);
Review Comment:
I'm also wondering if there's another way to do this, like wrap in a
Transaction::execute? LGTM otherwise
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
