sureshanaparti opened a new pull request, #9340: URL: https://github.com/apache/cloudstack/pull/9340
### Description This PR allows the below resource name / display text with unicode / emoji chars, and improves SQL exception msgs (doesn't include any sql stmts). Also, adds a validator for VM host/domain name. - User VM - Volume - Volume Snapshot - VM Snapshot - Template - ISO - Disk Offering - Compute Offering - Network Offering - VPC Offering - Backup Offering - Instance Group - Affinity Group - SSH Key - Userdata - Guest Network - VPC - Kubernetes Cluster - Autoscale VM Group - Account - User - Project <!--- Describe your changes in DETAIL - And how has behaviour functionally changed. --> <!-- For new features, provide link to FS, dev ML discussion etc. --> <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. --> <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged --> <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" --> <!-- Fixes: # --> <!--- ******************************************************************************* --> <!--- NOTE: AUTOMATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. --> <!--- PLEASE PUT AN 'X' in only **ONE** box --> <!--- ******************************************************************************* --> ### Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [x] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) - [ ] build/CI - [ ] test (unit or integration test code) ### Feature/Enhancement Scale or Bug Severity #### Feature/Enhancement Scale - [x] Major - [ ] Minor #### Bug Severity - [ ] BLOCKER - [ ] Critical - [ ] Major - [ ] Minor - [ ] Trivial ### Screenshots (if appropriate): ### How Has This Been Tested? Manually, tested the name / display names for these resources. test_resource_names.py [Checks support for emoji in the resource name for vm, volume, service & disk offering, template, iso, account(first/lastname)] ``` Test for deploy virtual machine ... === TestName: test_01_deploy_vm | Status : SUCCESS === ok Test for create volume ... === TestName: test_02_create_volume | Status : SUCCESS === ok Test for register template ... === TestName: test_03_register_template | Status : SUCCESS === ok Test for register ISO ... === TestName: test_04_register_iso | Status : SUCCESS === ok ---------------------------------------------------------------------- Ran 4 tests in 201.090s OK ``` <!-- Please describe in detail how you tested your changes. --> <!-- Include details of your testing environment, and the tests you ran to --> #### How did you try to break this feature and the system with this change? <!-- see how your change affects other areas of the code, etc. --> <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
