weizhouapache commented on code in PR #9330:
URL: https://github.com/apache/cloudstack/pull/9330#discussion_r1664381017
##########
plugins/database/quota/src/test/java/org/apache/cloudstack/api/response/QuotaResponseBuilderImplTest.java:
##########
@@ -334,7 +334,7 @@ public void
validateEndDateOnCreatingNewQuotaTariffTestEndDateLessThanNowThrowIn
@Test
public void validateEndDateOnCreatingNewQuotaTariffTestSetValidEndDate() {
Date startDate = DateUtils.addDays(date, -100);
- Date endDate = DateUtils.addMilliseconds(new Date(), 1);
+ Date endDate = DateUtils.addMinutes(new Date(), 1);
Review Comment:
is this change for an issue ?
##########
plugins/storage/volume/scaleio/src/main/java/org/apache/cloudstack/storage/datastore/manager/ScaleIOSDCManagerImpl.java:
##########
@@ -51,7 +52,7 @@
@Component
public class ScaleIOSDCManagerImpl implements ScaleIOSDCManager {
- private static final Logger LOGGER =
Logger.getLogger(ScaleIOSDCManagerImpl.class);
+ private static final Logger logger =
LogManager.getLogger(ScaleIOSDCManagerImpl.class);
Review Comment:
@vishesh92
I suggest to use
`LOGGER` for `final static` declaration
`logger` for variable
##########
engine/storage/volume/src/main/java/org/apache/cloudstack/storage/datastore/lifecycle/BasePrimaryDataStoreLifeCycleImpl.java:
##########
@@ -39,9 +38,12 @@
import com.cloud.storage.StoragePoolHostVO;
import com.cloud.storage.dao.StoragePoolHostDao;
import com.cloud.utils.Pair;
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
public class BasePrimaryDataStoreLifeCycleImpl {
- private static final Logger s_logger =
Logger.getLogger(BasePrimaryDataStoreLifeCycleImpl.class);
+ private static final Logger logger =
LogManager.getLogger(BasePrimaryDataStoreLifeCycleImpl.class);
Review Comment:
can use `LogManager.getLogger(getClass())` instead
@vishesh92
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
