DaanHoogland commented on code in PR #8801:
URL: https://github.com/apache/cloudstack/pull/8801#discussion_r1639483061
##########
plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/actionworkers/KubernetesClusterResourceModifierActionWorker.java:
##########
@@ -537,6 +521,7 @@ protected void removePortForwardingRules(final IpAddress
publicIp, final Network
for (PortForwardingRuleVO pfRule : pfRules) {
if (pfRule.getVirtualMachineId() == vmId) {
portForwardingRulesDao.remove(pfRule.getId());
+ logger.debug(String.format("The Port forwarding rule
[%s] with the id [%s] was removed.", pfRule.getName(), pfRule.getId()));
Review Comment:
see https://github.com/apache/cloudstack/pull/8801#discussion_r1639482249
##########
plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/actionworkers/KubernetesClusterResourceModifierActionWorker.java:
##########
@@ -524,6 +507,7 @@ protected FirewallRule removeSshFirewallRule(final
IpAddress publicIp) {
if (firewallRule.getSourcePortStart() ==
CLUSTER_NODES_DEFAULT_START_SSH_PORT) {
rule = firewallRule;
firewallService.revokeIngressFwRule(firewallRule.getId(),
true);
+ logger.debug(String.format("The SSH firewall rule [%s] with
the id [%s] was revoked",firewallRule.getName(),firewallRule.getId()));
Review Comment:
see https://github.com/apache/cloudstack/pull/8801#discussion_r1639482249
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
