shwstppr commented on code in PR #9248:
URL: https://github.com/apache/cloudstack/pull/9248#discussion_r1639345612
##########
plugins/hypervisors/xenserver/src/main/java/org/apache/cloudstack/hypervisor/xenserver/ExtraConfigurationUtility.java:
##########
@@ -169,12 +178,28 @@ private static void applyConfigWithKeyValue(Connection
conn, VM vm, Map<String,
}
}
- private static Map<String, String> prepareKeyValuePair(String cfg) {
- Map<String, String> configKeyPair = new HashMap<>();
+ private static Pair<String, String> prepareKeyValuePair(String cfg) {
Review Comment:
Should we add some unit tests for this methods?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
