rohityadavcloud opened a new pull request, #9177:
URL: https://github.com/apache/cloudstack/pull/9177
### Description
- Changes behaviour of details param handling via global setting:
- listVirtualMachines API: when the details param is not provided, it
returns `all` details excluding/including `stats` which is controllable by a
new global setting `list.vm.default.details.stats`
- listVirtualMachinesMetrics API: when the details param is not provided,
it uses `all` details including `stats`
- Users who are affected by the stats related change, can have backward
compatibility at the higher-cost of listVirtualMachines API response time by
setting `list.vm.default.details.stats` to true
- Remove ConfigKey vm.stats.increment.metrics.in.memory which was renamed to
`vm.stats.increment.metrics` in #5984 and also remove unused/unnecessary global
settings via upgrade path
- Changes default value of VM stats accumulation setting
`vm.stats.increment.metrics` to false until a better solution emerges. Since
#5984, this is true and during the execution of listVM APIs the stats are
clubbed/calculated which can immensely slow down list VM API calls.
- Fix UI that uses listVirtualMachinesMetrics to not call `stats` detail
when in list view without metrics selected.
### Types of changes
- [x] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [x] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [x] Major
- [ ] Minor
- [ ] Trivial
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
