weizhouapache commented on code in PR #8740:
URL: https://github.com/apache/cloudstack/pull/8740#discussion_r1622701710
##########
engine/schema/src/main/java/com/cloud/vm/dao/VmStatsDao.java:
##########
@@ -75,8 +75,9 @@ public interface VmStatsDao extends GenericDao<VmStatsVO,
Long> {
/**
* Removes (expunges) all VM stats with {@code timestamp} less than
* a given Date.
- * @param limit the maximum date to keep stored. Records that exceed this
limit will be removed.
+ * @param limitDate the maximum date to keep stored. Records that exceed
this limit will be removed.
+ * @param limitPerQuery the maximum amount of rows to be removed in a
single query. We loop if there are still rows to be removed after a given query.
*/
- void removeAllByTimestampLessThan(Date limit);
+ void removeAllByTimestampLessThan(Date limitDate, Long limitPerQuery);
Review Comment:
Long means it could be null
Is _long_ better?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
