shwstppr commented on code in PR #9070:
URL: https://github.com/apache/cloudstack/pull/9070#discussion_r1621982060
##########
plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/version/KubernetesVersionManagerImpl.java:
##########
@@ -331,12 +345,14 @@ public KubernetesSupportedVersionResponse
addKubernetesSupportedVersion(final Ad
KubernetesSupportedVersionVO supportedVersionVO = new
KubernetesSupportedVersionVO(name, semanticVersion, template.getId(), zoneId,
minimumCpu, minimumRamSize);
supportedVersionVO =
kubernetesSupportedVersionDao.persist(supportedVersionVO);
+
CallContext.current().putContextParameter(KubernetesSupportedVersion.class,
supportedVersionVO.getUuid());
return createKubernetesSupportedVersionResponse(supportedVersionVO);
}
@Override
- @ActionEvent(eventType =
KubernetesVersionEventTypes.EVENT_KUBERNETES_VERSION_DELETE, eventDescription =
"Deleting Kubernetes supported version", async = true)
+ @ActionEvent(eventType =
KubernetesVersionEventTypes.EVENT_KUBERNETES_VERSION_DELETE,
+ eventDescription = "deleting Kubernetes supported version", async
= true)
Review Comment:
We have some code in ActionEventUtils or Interprator which prefixes
`Successfully completed` to the event description
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
