bernardodemarco commented on code in PR #8924:
URL: https://github.com/apache/cloudstack/pull/8924#discussion_r1583716662
##########
services/console-proxy/server/src/main/java/com/cloud/consoleproxy/ConsoleProxyNoVNCHandler.java:
##########
@@ -104,20 +105,20 @@ public void onConnect(final Session session) throws
IOException, InterruptedExce
try {
port = Integer.parseInt(portStr);
} catch (NumberFormatException e) {
- logger.error("Invalid port value in query string: {}. Expected a
number.", portStr, e);
+ logger.error(String.format("Invalid port value in query string:
%s. Expected a number.", portStr), e);
Review Comment:
@DaanHoogland, I changed the `logger` fields of those two classes to use
`log4j` directly, in order to be able to use the new syntax. Afterwards, I
manually verified the log messages, and they seem to be ok.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
