abh1sar commented on code in PR #8947:
URL: https://github.com/apache/cloudstack/pull/8947#discussion_r1583432991
##########
server/src/main/java/com/cloud/storage/StoragePoolAutomationImpl.java:
##########
@@ -318,9 +323,12 @@ public boolean cancelMaintain(DataStore store) {
if (hosts == null || hosts.size() == 0) {
return true;
}
+
+ Map<String, String> details = new HashMap<>();
Review Comment:
I kept it outside thinking that other kind of details can be added to
`details` map later
For ex. we can have something like this in future
```
Map<String, String> details = new HashMap<>();
storageManager.addStoragePoolNFSMountOptsToDetailsMap(pool, details);
storageManager.addStoragePoolFutureFieldToDetailsMap(pool, details);
```
I can move it to the method if you think this is overkill.
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtStoragePoolDef.java:
##########
@@ -75,6 +82,15 @@ public LibvirtStoragePoolDef(PoolType type, String poolName,
String uuid, String
_targetPath = targetPath;
}
+ public LibvirtStoragePoolDef(PoolType type, String poolName, String uuid,
String host, String dir, String targetPath, List<String> nfsMountOpts) {
+ this(type, poolName, uuid, host, dir, targetPath);
+ if (CollectionUtils.isNotEmpty(nfsMountOpts)) {
+ for (String nfsMountOpt : nfsMountOpts) {
+ this._nfsMountOpts.put(nfsMountOpt, null);
Review Comment:
Set would be perfect. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
