(cloudstack) branch main updated: Limit infrastructure details revealed to the end user after a failed migration on KVM (#8680)

[joao]

This is an automated email from the ASF dual-hosted git repository.

joao pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/main by this push:
     new 31f28f6516d Limit infrastructure details revealed to the end user 
after a failed migration on KVM (#8680)
31f28f6516d is described below

commit 31f28f6516ddc81b8bca2a1b98734536e1733594
Author: GaOrtiga <49285692+gaort...@users.noreply.github.com>
AuthorDate: Tue Apr 16 09:58:35 2024 -0300

    Limit infrastructure details revealed to the end user after a failed 
migration on KVM (#8680)
    
    * remove details when error occurs
    
    * Update 
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtMigrateCommandWrapper.java
    
    Co-authored-by: dahn <daan.hoogl...@gmail.com>
    
    ---------
    
    Co-authored-by: Gabriel <gabriel.fernan...@scclouds.com.br>
    Co-authored-by: dahn <daan.hoogl...@gmail.com>
---
 .../hypervisor/kvm/resource/wrapper/LibvirtMigrateCommandWrapper.java  | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git 
a/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtMigrateCommandWrapper.java
 
b/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtMigrateCommandWrapper.java
index 210af77f84a..c24214dd68c 100644
--- 
a/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtMigrateCommandWrapper.java
+++ 
b/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtMigrateCommandWrapper.java
@@ -308,7 +308,8 @@ public final class LibvirtMigrateCommandWrapper extends 
CommandWrapper<MigrateCo
             logger.error(String.format("Can't migrate domain [%s] due to: 
[%s].", vmName, e.getMessage()), e);
             result = e.getMessage();
             if (result.startsWith("unable to connect to server") && 
result.endsWith("refused")) {
-                result = String.format("Migration was refused connection to 
destination: %s. Please check libvirt configuration compatibility and firewall 
rules on the source and destination hosts.", destinationUri);
+                logger.debug("Migration failed as connection to destination 
[{}] was refused. Please check libvirt configuration compatibility and firewall 
rules on the source and destination hosts.", destinationUri);
+                result = String.format("Failed to migrate domain [%s].", 
vmName);
             }
         } catch (final InterruptedException
             | ExecutionException