weizhouapache commented on code in PR #8904:
URL: https://github.com/apache/cloudstack/pull/8904#discussion_r1562487992
##########
engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java:
##########
@@ -1720,6 +1720,9 @@ private Pair<VolumeVO, DataStore> recreateVolume(VolumeVO
vol, VirtualMachinePro
DiskOffering diskOffering =
_entityMgr.findById(DiskOffering.class, vol.getDiskOfferingId());
if (diskOffering.getEncrypt()) {
vol = setPassphraseForVolumeEncryption(vol);
+ } else if (vol.getPassphraseId() != null) {
+ vol.setPassphraseId(null);
+ _volsDao.persist(vol);
Review Comment:
@vishesh92
code lgtm
but, what has happened to the volume ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
