External UUID control: as only Root admin can change external UUID, so modified @Parameter to enforce the check
Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/e51d472b Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/e51d472b Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/e51d472b Branch: refs/heads/rbac Commit: e51d472b0cfda56db91fc82728c6bb29016e4d50 Parents: 4305d81 Author: Alena Prokharchyk <alena.prokharc...@citrix.com> Authored: Wed Feb 5 15:28:34 2014 -0800 Committer: Alena Prokharchyk <alena.prokharc...@citrix.com> Committed: Wed Feb 5 15:56:40 2014 -0800 ---------------------------------------------------------------------- api/src/org/apache/cloudstack/api/BaseAsyncCustomIdCmd.java | 3 ++- api/src/org/apache/cloudstack/api/BaseCustomIdCmd.java | 4 +++- 2 files changed, 5 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/cloudstack/blob/e51d472b/api/src/org/apache/cloudstack/api/BaseAsyncCustomIdCmd.java ---------------------------------------------------------------------- diff --git a/api/src/org/apache/cloudstack/api/BaseAsyncCustomIdCmd.java b/api/src/org/apache/cloudstack/api/BaseAsyncCustomIdCmd.java index dfb9439..b251c6e 100644 --- a/api/src/org/apache/cloudstack/api/BaseAsyncCustomIdCmd.java +++ b/api/src/org/apache/cloudstack/api/BaseAsyncCustomIdCmd.java @@ -16,11 +16,12 @@ // under the License. package org.apache.cloudstack.api; +import org.apache.cloudstack.acl.RoleType; public abstract class BaseAsyncCustomIdCmd extends BaseAsyncCmd { @Parameter(name = ApiConstants.CUSTOM_ID, type = CommandType.STRING, - description = "an optional field, in case you want to set a custom id to the resource. Allowed to Root Admins only", since = "4.4") + description = "an optional field, in case you want to set a custom id to the resource. Allowed to Root Admins only", since = "4.4", authorized = {RoleType.Admin}) private String customId; public String getCustomId() { http://git-wip-us.apache.org/repos/asf/cloudstack/blob/e51d472b/api/src/org/apache/cloudstack/api/BaseCustomIdCmd.java ---------------------------------------------------------------------- diff --git a/api/src/org/apache/cloudstack/api/BaseCustomIdCmd.java b/api/src/org/apache/cloudstack/api/BaseCustomIdCmd.java index 942f29f..7ca9f1e 100644 --- a/api/src/org/apache/cloudstack/api/BaseCustomIdCmd.java +++ b/api/src/org/apache/cloudstack/api/BaseCustomIdCmd.java @@ -16,11 +16,13 @@ // under the License. package org.apache.cloudstack.api; +import org.apache.cloudstack.acl.RoleType; + public abstract class BaseCustomIdCmd extends BaseCmd { @Parameter(name = ApiConstants.CUSTOM_ID, type = CommandType.STRING, - description = "an optional field, in case you want to set a custom id to the resource. Allowed to Root Admins only", since = "4.4") + description = "an optional field, in case you want to set a custom id to the resource. Allowed to Root Admins only", since = "4.4", authorized = {RoleType.Admin}) private String customId; public String getCustomId() {