DaanHoogland commented on code in PR #8530:
URL: https://github.com/apache/cloudstack/pull/8530#discussion_r1511191524
##########
services/secondary-storage/server/src/main/java/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java:
##########
@@ -2287,22 +2287,39 @@ public synchronized String
allowOutgoingOnPrivate(String destCidr) {
if (!_inSystemVM) {
return null;
}
- Script command = new Script("/bin/bash", s_logger);
String intf = "eth1";
- command.add("-c");
- command.add("iptables -I OUTPUT -o " + intf + " -d " + destCidr + " -p
tcp -m state --state NEW -m tcp -j ACCEPT");
+ String rule = String.format("OUTPUT -o %s -d %s -p tcp -m state
--state NEW -m tcp -j ACCEPT", intf, destCidr);
- String result = command.execute();
- if (result != null) {
- s_logger.warn("Error in allowing outgoing to " + destCidr + ",
err=" + result);
- return "Error in allowing outgoing to " + destCidr + ", err=" +
result;
+ if (ruleNeedsAdding(rule)) {
Review Comment:
```suggestion
s_logger.info("Adding rule if required: {}" , rule);
if (ruleNeedsAdding(rule)) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
