DaanHoogland commented on PR #8698: URL: https://github.com/apache/cloudstack/pull/8698#issuecomment-1961625022
> @DaanHoogland Thanks for the review. > > > CLGTM, but don't you think the replacement code should be called inside the `VirtualMachine.add<>()` methods, @gpordeus ? > > Do you mean the original methods (`VM.addToVCPUsParams()`, `VM.addToHVMBootParams()`, etc)? It would be better, but those are part of the xenapi :/ right, I thought these were in a wrapper :( ok, don't bother -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
