weizhouapache commented on PR #8654: URL: https://github.com/apache/cloudstack/pull/8654#issuecomment-1944637308
> @weizhouapache > > > I agree this setting should by dynamic, and it is better to be a zone-level setting. > > Since the maximum number of networks per VPC depends on the hypervisor where the VR is deployed (as pointed out in the description), I don't think it makes sense to change it to the zone level as the cluster is the highest possible structure to define a hypervisor. > > > But, vpc does not belong to a cluster and vms in vpc might run with different hypervisors, in different clusters. > > The setting value is defined by the cluster in which the VPC's VR is running, using the lowest value found if the VPC has more than one VR and they are in different clusters (https://github.com/apache/cloudstack/pull/8654/files#diff-07bd71d9f58832d4429d7743f4887188a96aacc913dc48e0101470147ce42032R1893-R1922). Regarding `and vms in vpc might run with different hypervisors`, VMs running in different hypervisors do not impact in the VPC creation; therefore, does not make sense to consider it in the algorithm. I can understand your code. Your requirement is not clear to me. Can you explain more about the infrastructure? e.g. the hypervisor types, why the max vpc networks are different, what are the issues? Can it be a domain or account setting? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
