Re: [PR] Fix false positives in Usage sanity checks of templates and network offerings [cloudstack]

[via GitHub]

JoaoJandre commented on code in PR #8136:
URL: https://github.com/apache/cloudstack/pull/8136#discussion_r1483102167


##########
usage/src/main/java/com/cloud/usage/UsageSanityChecker.java:
##########
@@ -195,6 +213,7 @@ protected void readLastCheckId(){
             String lastIdText = null;
             lastId = -1;
             if ((lastIdText = reader.readLine()) != null) {
+                s_logger.info(String.format("Read [%s] as lastId for Usage 
sanity checking.", lastIdText));

Review Comment:
   ```suggestion
                   logger.info("Read {} as lastId for Usage sanity checking.", 
lastIdText);
   ```



##########
usage/src/main/java/com/cloud/usage/UsageSanityChecker.java:
##########
@@ -213,7 +232,9 @@ protected void readMaxId() throws SQLException {
             maxId = -1;
             if (rs.next() && (rs.getInt(1) > 0)) {
                 maxId = rs.getInt(1);
+                s_logger.info(String.format("Read [%s] as maxId for Usage 
sanity checking.", maxId));

Review Comment:
   ```suggestion
                   logger.info("Read {} as maxId for Usage sanity checking.", 
maxId);
   ```



##########
usage/src/main/java/com/cloud/usage/UsageSanityChecker.java:
##########
@@ -213,7 +232,9 @@ protected void readMaxId() throws SQLException {
             maxId = -1;
             if (rs.next() && (rs.getInt(1) > 0)) {
                 maxId = rs.getInt(1);
+                s_logger.info(String.format("Read [%s] as maxId for Usage 
sanity checking.", maxId));
                 if (maxId > lastId) {
+                    s_logger.info(String.format("The max id [%s] is greater 
than the last id [%s]; adding id check to the query.", maxId, lastId));

Review Comment:
   ```suggestion
                       logger.info("The max id {} is greater than the last id 
{}; adding id check to the query.", maxId, lastId);
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org