harikrishna-patnala commented on code in PR #8547:
URL: https://github.com/apache/cloudstack/pull/8547#discussion_r1464718607
##########
agent/src/main/java/com/cloud/agent/properties/AgentProperties.java:
##########
@@ -659,6 +659,14 @@ public class AgentProperties{
*/
public static final Property<Integer> STOP_SCRIPT_TIMEOUT = new
Property<>("stop.script.timeout", 120);
+ /**
+ * Time (in seconds) to wait for scripts to complete.<br>
+ * This is not used for every script execution.<br>
+ * Data type: Integer.<br>
+ * Default value: <code>60</code>
+ */
+ public static final Property<Integer> AGENT_SCRIPT_TIMEOUT = new
Property<>("agent.script.timeout", 60);
Review Comment:
yeah correct but that has to be known to the operator right, we normally put
them in the properties file and comment them
eg.
# Instance Conversion from Vmware to KVM through virt-v2v. Enable verbose
mode
# virtv2v.verbose.enabled=false
##########
agent/src/main/java/com/cloud/agent/properties/AgentProperties.java:
##########
@@ -659,6 +659,14 @@ public class AgentProperties{
*/
public static final Property<Integer> STOP_SCRIPT_TIMEOUT = new
Property<>("stop.script.timeout", 120);
+ /**
+ * Time (in seconds) to wait for scripts to complete.<br>
+ * This is not used for every script execution.<br>
+ * Data type: Integer.<br>
+ * Default value: <code>60</code>
+ */
+ public static final Property<Integer> AGENT_SCRIPT_TIMEOUT = new
Property<>("agent.script.timeout", 60);
Review Comment:
yeah correct but that has to be known to the operator right, we normally put
them in the properties file and comment them
eg.
```
# Instance Conversion from Vmware to KVM through virt-v2v. Enable verbose
mode
# virtv2v.verbose.enabled=false
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
