DaanHoogland commented on code in PR #8045:
URL: https://github.com/apache/cloudstack/pull/8045#discussion_r1363494501
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/KVMHAMonitor.java:
##########
@@ -87,41 +88,39 @@ protected void runHeartBeat() {
synchronized (storagePool) {
Review Comment:
this hase bcome a very complex method. synchronised-for-if-try--if and then
some after the closing catch. should it be disected for readability and
maintainability?
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMStoragePoolManager.java:
##########
@@ -360,9 +360,10 @@ private synchronized KVMStoragePool
createStoragePool(String name, String host,
KVMStoragePool pool = adaptor.createStoragePool(name, host, port,
path, userInfo, type, details);
// LibvirtStorageAdaptor-specific statement
- if (type == StoragePoolType.NetworkFilesystem && primaryStorage) {
- KVMHABase.NfsStoragePool nfspool = new
KVMHABase.NfsStoragePool(pool.getUuid(), host, path, pool.getLocalPath(),
PoolType.PrimaryStorage);
- _haMonitor.addStoragePool(nfspool);
+ if (pool.isPoolSupportHA() && primaryStorage) {
+ //KVMHABase.HAStoragePool nfspool = new
KVMHABase.HAStoragePool(pool.getUuid(), host, path, pool.getLocalPath(),
PoolType.PrimaryStorage);
Review Comment:
commented code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
