weizhouapache commented on issue #7783:
URL: https://github.com/apache/cloudstack/issues/7783#issuecomment-1661294460

   > > copying from [#7095 
(comment)](https://github.com/apache/cloudstack/pull/7095#issuecomment-1655190491)
 :
   > > @weizhouapache @BryanMLima , seems like we need;
   > > 
   > > 1. a reconsiliation method (merging duplicates)
   > > 2. an extra check in addGuestOsAndHypervisorMappings to make sure such 
situations don't arise again
   > 
   > Agree with this approach, I had a quick discussion with @weizhouapache on 
this in similar terms.
   > 
   > On the second part "an extra check in addGuestOsAndHypervisorMappings to 
make sure such situations don't arise again", for guest OS entry check, do we 
need to mark "is_user_defined" as false? which I dont think it is not required 
to change, since it is already added.
   
   yes @harikrishna-patnala 
   based on what we have discussed, I pushed a commit to shapeblue repository. 
see #7799
   
   we can work together to fix it. @DaanHoogland @harikrishna-patnala 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to