harikrishna-patnala commented on PR #7793:
URL: https://github.com/apache/cloudstack/pull/7793#issuecomment-1660324536

   @nvazquez @DaanHoogland 
   
   I saw there is an extra parameter for this updateVirtualMachine API which is 
"extraconfig". 
   
https://github.com/apache/cloudstack/blob/713a236843c0c51f248d1bf05d198f935e6bf13d/api/src/main/java/org/apache/cloudstack/api/command/user/vm/UpdateVMCmd.java#L147-L148
   
   From UI, we are using "details" parameters through which extraconfig key is 
blocked. This is causing the actual issue.
   
   If we use the separate parameter "extraconfig" in the API then the value 
will be saved based on the global settings "enable.additional.vm.configuration".
   
   So I think what we can do here is (if at all we decide to allow extraconfig 
from UI) to check if the detail key is "extraconfig" and then send the value in 
API parameter "extraconfig" (not the "details").


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to