[GitHub] [cloudstack] GutoVeronezi commented on pull request #6348: Improving code related to the Agent properties

[GitBox]

GutoVeronezi commented on PR #6348:
URL: https://github.com/apache/cloudstack/pull/6348#issuecomment-1353487861

   @DaanHoogland I think I found out what was happening. When patching the 
system VMs, the file `systemvm/agent/conf/agent.properties` is copied to them. 
This file contains two hardcoded properties:
   ```
   instance=ConsoleProxy
   resource=com.cloud.agent.resource.consoleproxy.ConsoleProxyResource
   ```
   As `AgentShell` was changed to use the configurations from 
`agent.properties` instead of the parameters passed in the command line, the 
SSVM was being started with the hardcoded property `resource` 
(`com.cloud.agent.resource.consoleproxy.ConsoleProxyResource`) and trying to 
start as a CPVM.
   
   I made a change to remove those hardcoded properties when the system VM is a 
SSVM and to copy the content of file `/var/cache/cloud/cmdline` to 
`agent.properties` during the bootstrap, making `AgentShell` use the proper 
properties.
   
   Following there is the content of the `agent.properties` of both system VMs 
after the change:
   
   For SSVM
   
![image](https://user-images.githubusercontent.com/38945620/207911119-3859358d-0d59-48f6-b107-57cf65add288.png)
   
   For CPVM
   
![image](https://user-images.githubusercontent.com/38945620/207911404-7115ec98-dc66-4a0e-9f53-a78b8b905b9a.png)
   
   ---
   
   @DaanHoogland, can we run the tests again?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org