ravening commented on a change in pull request #4646:
URL: https://github.com/apache/cloudstack/pull/4646#discussion_r718242770
##########
File path:
server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java
##########
@@ -422,6 +426,13 @@
"Indicates whether the host in down state can be put
into maintenance state so thats its not enabled after it comes back.",
true, ConfigKey.Scope.Zone, null);
+ protected final ConfigKey<Integer> KvmVmMigrateSpeed = new
ConfigKey<>("Advanced", Integer.class, KVM_VM_MIGRATE_SPEED, "-1",
+ "set the vm migrate speed (in MiB/s) on KVM. By default, it will
try to guess the speed of the guest network (in MBps).", true);
+ protected final ConfigKey<Integer> KvmVmMigrateDowntime = new
ConfigKey<>("Advanced", Integer.class, KVM_VM_MIGRATE_DOWNTIME, "-1",
+ "Sets maximum tolerable time in milliseconds for which the domain
is allowed to be paused at the end of live migration on KVM.", true);
+ protected final ConfigKey<Integer> KvmVmMigratePauseAfter = new
ConfigKey<>("Advanced", Integer.class, KVM_VM_MIGRATE_PAUSE_AFTER, "-1",
+ "Set an upper limit in milliseconds for how long live migration on
KVM should wait, at which point VM is paused and migration will finish quickly.
Less than 1 means disabled.", true);
+
Review comment:
@DaanHoogland @weizhouapache moved the settings to `KVMguru`
##########
File path:
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
##########
@@ -654,6 +658,54 @@ public String interpret(final BufferedReader reader)
throws IOException {
}
}
+ /**
+ * setLiveMigrateFlags
+ *
+ * Sets the user configured live migration flags
+ *
+ * @param params
+ */
+ public void setLiveMigrateFlags(final Map<String, String> params) {
+ if (params.get(KVM_VM_MIGRATE_SPEED) != null) {
+ _migrateSpeed =
NumbersUtil.parseInt(params.get(KVM_VM_MIGRATE_SPEED), -1);
Review comment:
changed
##########
File path:
server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java
##########
@@ -453,6 +457,12 @@
"Max length of vm userdata after base64 decoding. Default is 32768
and maximum is 1048576", true);
public static final ConfigKey<Boolean> MIGRATE_VM_ACROSS_CLUSTERS = new
ConfigKey<Boolean>(Boolean.class, "migrate.vm.across.clusters", "Advanced",
"false",
"Indicates whether the VM can be migrated to different cluster if
no host is found in same cluster",true, ConfigKey.Scope.Zone, null);
+ protected final ConfigKey<Integer> KvmVmMigrateSpeed = new
ConfigKey<>("Advanced", Integer.class, KVM_VM_MIGRATE_SPEED, "-1",
Review comment:
changed to cluster scope
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]