huyle-uni commented on a change in pull request #4205:
URL: https://github.com/apache/cloudstack/pull/4205#discussion_r708814042



##########
File path: 
plugins/network-elements/tungsten/src/main/java/com/cloud/network/guru/TungstenGuestNetworkGuru.java
##########
@@ -14,7 +14,7 @@
 // KIND, either express or implied.  See the License for the
 // specific language governing permissions and limitations
 // under the License.
-package org.apache.cloudstack.network.tungsten.service;
+package com.cloud.network.guru;

Review comment:
       Could you please explain me why we can not have new in com.cloud ?
   I saw some plugin like BigSwitchBcf, BrocadeVcs, cisco, ElasticLb, ... in 
com.cloud. And they have unit test for NetworkGuru.
   While some plugin like Opendaylight, SspGuest not in com.cloud. And they 
have no unit test for NetworkGuru.
   So does it have any difference between them ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to