sureshanaparti commented on a change in pull request #4701:
URL: https://github.com/apache/cloudstack/pull/4701#discussion_r595775182
##########
File path:
plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/manager/VmwareManager.java
##########
@@ -46,6 +46,9 @@
static final ConfigKey<Integer> s_vmwareOVAPackageTimeout = new
ConfigKey<Integer>(Integer.class, "vmware.package.ova.timeout", "Advanced",
"3600",
"Vmware script timeout for ova packaging process", true,
ConfigKey.Scope.Global, 1000);
+ static final ConfigKey<Boolean> s_vmwareCleanupPortGroups = new
ConfigKey<Boolean>("Advanced", Boolean.class, "vmware.cleanup.port.groups",
"false",
+ "Remove unused port groups. WARNING: When set to true, native
VMware HA might not work.", true, ConfigKey.Scope.Global);
Review comment:
@Spaceman1984 If my understanding is correct, cleanup port groups
happens only on the network cleanup only and the old uncleaned port groups of
other networks (when this setting is false) still remains. If so, Can you
mention in the setting description that port groups cleanup happens on the
network cleanup for that network only.
Is it possible to clean old port groups of other networks through any
garbage collector, when this setting is true.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
