GutoVeronezi opened a new pull request #4780: URL: https://github.com/apache/cloudstack/pull/4780
### Description ACS, with KVM, cannot migrate VM's volumes from a `SharedMountPoint` to a `NFS` storage pool properly; it will not copy the volumes's template to the destination storage pool (if needed), neither update the VM's XML properly. From a `SharedMountPoint` to a `NFS` storage pool, ACS used to interpret that it would use `localhost` as the host of the storage system; as it is a shared mount point configured in all cluster's host, as server name, but `NFS` retrieves its path from KVM, so it needs to keep the same behavior as `NFS` to `NFS`. This PR intends to enable migration between NFS <> ISCSI (via sharedmountpoint) in KVM. ### Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [x] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ### Feature/Enhancement Scale or Bug Severity #### Feature/Enhancement Scale - [ ] Major - [x] Minor ### How Has This Been Tested? It has been tested locally in a test lab. 1. I created a VM; 2. I configured 2 primary storages, 1 as NFS and 1 as SharedMountPoint; 3. I tried to migrate VM (with `migrateVirtualMachineWithVolume`) from a SharedMountPoint to a NFS, but it threw a Exception due to incorrect path on VM's XML; -- After appling this patch the migration works. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
